Add optional buffer argument to Cipher#final #990
+208
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds an optional buffer argument to the Cipher#final method, matching the behavior of Cipher#update. When a buffer is provided, the output is written to it and the same buffer object is returned. Otherwise, a new string is created and returned. The implementation follows the same pattern as update: - Accepts an optional string buffer parameter - Reuses the buffer if provided, creating a new string if not - Automatically resizes the buffer as needed - Forces ASCII-8BIT encoding for binary cipher output - Raises FrozenError if the buffer is frozen
Member
|
Why is this needed or desirable? |
Contributor
Author
|
It allows using a cipher to only require a single string allocation, by reusing the buffer passed to update, as opposed to allocating a second string inside |
Member
|
Have you measured the performance impact?
|
Contributor
Author
|
On one request I was profiling, we were allocating 140784 objects there just for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an optional buffer argument to the Cipher#final method, matching the behavior of Cipher#update. When a buffer is provided, the output is written to it and the same buffer object is returned. Otherwise, a new string is created and returned.
The implementation follows the same pattern as update: